]> Gentwo Git Trees - linux/.git/commitdiff
comedi: Adjust range_table_list allocation type
authorKees Cook <kees@kernel.org>
Sat, 26 Apr 2025 06:10:16 +0000 (23:10 -0700)
committerKees Cook <kees@kernel.org>
Mon, 24 Nov 2025 20:43:28 +0000 (12:43 -0800)
In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The returned type is "struct comedi_lrange **", but the assigned type,
while technically matching, is const qualified. Since there is no general
way to remove const qualifiers, switch the returned type to match the
assign type. No change in allocation size results.

Link: https://patch.msgid.link/20250426061015.work.971-kees@kernel.org
Signed-off-by: Kees Cook <kees@kernel.org>
drivers/comedi/drivers/ni_670x.c

index c875d251c23021888cba3bd0ed40f0e84e4f783b..563a9c790f12348f961374fc8b4904a3c0db2e89 100644 (file)
@@ -199,7 +199,7 @@ static int ni_670x_auto_attach(struct comedi_device *dev,
                const struct comedi_lrange **range_table_list;
 
                range_table_list = kmalloc_array(32,
-                                                sizeof(struct comedi_lrange *),
+                                                sizeof(*range_table_list),
                                                 GFP_KERNEL);
                if (!range_table_list)
                        return -ENOMEM;