iavf: clarify VLAN add/delete log messages and lower log level

The current dev_warn messages for too many VLAN changes are confusing
and one place incorrectly references "add" instead of "delete" VLANs
due to copy-paste errors.

- Use dev_info instead of dev_warn to lower the log level.
- Rephrase the message to: "virtchnl: Too many VLAN [add|delete]
  ([v1|v2]) requests; splitting into multiple messages to PF\n".

Suggested-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Link: https://patch.msgid.link/20251125223632.1857532-12-anthony.l.nguyen@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
index 34a422a4a29c1b9487e7debc1ad0ba8fe91be43e..88156082a41da6ad1653952d224c8ca1bf4256de 100644 (file)
--- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c
@@ -793,7 +793,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter)
 
                len = virtchnl_struct_size(vvfl, vlan_id, count);
                if (len > IAVF_MAX_AQ_BUF_SIZE) {
-                       dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
+                       dev_info(&adapter->pdev->dev,
+                                "virtchnl: Too many VLAN add (v1) requests; splitting into multiple messages to PF\n");
                        while (len > IAVF_MAX_AQ_BUF_SIZE)
                                len = virtchnl_struct_size(vvfl, vlan_id,
                                                           --count);
@@ -838,7 +839,8 @@ void iavf_add_vlans(struct iavf_adapter *adapter)
 
                len = virtchnl_struct_size(vvfl_v2, filters, count);
                if (len > IAVF_MAX_AQ_BUF_SIZE) {
-                       dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
+                       dev_info(&adapter->pdev->dev,
+                                "virtchnl: Too many VLAN add (v2) requests; splitting into multiple messages to PF\n");
                        while (len > IAVF_MAX_AQ_BUF_SIZE)
                                len = virtchnl_struct_size(vvfl_v2, filters,
                                                           --count);
@@ -941,7 +943,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter)
 
                len = virtchnl_struct_size(vvfl, vlan_id, count);
                if (len > IAVF_MAX_AQ_BUF_SIZE) {
-                       dev_warn(&adapter->pdev->dev, "Too many delete VLAN changes in one request\n");
+                       dev_info(&adapter->pdev->dev,
+                                "virtchnl: Too many VLAN delete (v1) requests; splitting into multiple messages to PF\n");
                        while (len > IAVF_MAX_AQ_BUF_SIZE)
                                len = virtchnl_struct_size(vvfl, vlan_id,
                                                           --count);
@@ -987,7 +990,8 @@ void iavf_del_vlans(struct iavf_adapter *adapter)
 
                len = virtchnl_struct_size(vvfl_v2, filters, count);
                if (len > IAVF_MAX_AQ_BUF_SIZE) {
-                       dev_warn(&adapter->pdev->dev, "Too many add VLAN changes in one request\n");
+                       dev_info(&adapter->pdev->dev,
+                                "virtchnl: Too many VLAN delete (v2) requests; splitting into multiple messages to PF\n");
                        while (len > IAVF_MAX_AQ_BUF_SIZE)
                                len = virtchnl_struct_size(vvfl_v2, filters,
                                                           --count);