]> Gentwo Git Trees - linux/.git/commitdiff
wifi: mt76: mt7615: check devm_kasprintf() returned value
authorMa Ke <make24@iscas.ac.cn>
Thu, 5 Sep 2024 01:47:53 +0000 (09:47 +0800)
committerFelix Fietkau <nbd@nbd.name>
Fri, 6 Sep 2024 12:23:07 +0000 (14:23 +0200)
devm_kasprintf() can return a NULL pointer on failure but this returned
value is not checked. Fix this lack and check the returned value.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: 0bb4e9187ea4 ("mt76: mt7615: fix hwmon temp sensor mem use-after-free")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Link: https://patch.msgid.link/20240905014753.353271-1-make24@iscas.ac.cn
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7615/init.c

index f9274c130c57fdb936cef6cf8c55911b88fdec28..66ba3be2734344a41b6fc697dc79422673e3e8c2 100644 (file)
@@ -56,6 +56,9 @@ int mt7615_thermal_init(struct mt7615_dev *dev)
 
        name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7615_%s",
                              wiphy_name(wiphy));
+       if (!name)
+               return -ENOMEM;
+
        hwmon = devm_hwmon_device_register_with_groups(&wiphy->dev, name, dev,
                                                       mt7615_hwmon_groups);
        return PTR_ERR_OR_ZERO(hwmon);