]> Gentwo Git Trees - linux/.git/commitdiff
iommu/vt-d: Fix unused invalidation hint in qi_desc_iotlb
authorAashish Sharma <aashish@aashishsharma.net>
Wed, 19 Nov 2025 05:16:13 +0000 (13:16 +0800)
committerJoerg Roedel <joerg.roedel@amd.com>
Thu, 20 Nov 2025 10:33:04 +0000 (11:33 +0100)
Invalidation hint (ih) in the function 'qi_desc_iotlb' is initialized
to zero and never used. It is embedded in the 0th bit of the 'addr'
parameter. Get the correct 'ih' value from there.

Fixes: f701c9f36bcb ("iommu/vt-d: Factor out invalidation descriptor composition")
Signed-off-by: Aashish Sharma <aashish@aashishsharma.net>
Link: https://lore.kernel.org/r/20251009010903.1323979-1-aashish@aashishsharma.net
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
drivers/iommu/intel/iommu.h

index 3056583d7f56b2bd0794890973011629476d6eac..dcc5466d35f9337f59159314a4b7d48881f100ac 100644 (file)
@@ -1097,7 +1097,7 @@ static inline void qi_desc_iotlb(struct intel_iommu *iommu, u16 did, u64 addr,
                                 struct qi_desc *desc)
 {
        u8 dw = 0, dr = 0;
-       int ih = 0;
+       int ih = addr & 1;
 
        if (cap_write_drain(iommu->cap))
                dw = 1;