]> Gentwo Git Trees - linux/.git/commitdiff
drm/solomon: Simplify mode_valid() using DRM helper
authorIker Pedrosa <ikerpedrosam@gmail.com>
Sat, 20 Sep 2025 09:45:43 +0000 (11:45 +0200)
committerJavier Martinez Canillas <javierm@redhat.com>
Fri, 26 Sep 2025 13:04:46 +0000 (15:04 +0200)
The ssd130x_crtc_mode_valid() function contains a manual implementation
to validate the display mode against the panel's single fixed resolution.

This pattern is common for simple displays, and the DRM core already
provides the drm_crtc_helper_mode_valid_fixed() helper for this exact
use case.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
Link: https://lore.kernel.org/r/20250920-improve-ssd130x-v2-3-77721e87ae08@gmail.com
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
drivers/gpu/drm/solomon/ssd130x.c

index 09792be46f91e385a7813fb6e1d04ab392ec7435..80ff9005c104efcdd395131dcfce2fd14c6806d0 100644 (file)
@@ -1473,15 +1473,7 @@ static enum drm_mode_status ssd130x_crtc_mode_valid(struct drm_crtc *crtc,
 {
        struct ssd130x_device *ssd130x = drm_to_ssd130x(crtc->dev);
 
-       if (mode->hdisplay != ssd130x->mode.hdisplay &&
-           mode->vdisplay != ssd130x->mode.vdisplay)
-               return MODE_ONE_SIZE;
-       else if (mode->hdisplay != ssd130x->mode.hdisplay)
-               return MODE_ONE_WIDTH;
-       else if (mode->vdisplay != ssd130x->mode.vdisplay)
-               return MODE_ONE_HEIGHT;
-
-       return MODE_OK;
+       return drm_crtc_helper_mode_valid_fixed(crtc, mode, &ssd130x->mode);
 }
 
 static int ssd130x_crtc_atomic_check(struct drm_crtc *crtc,