]> Gentwo Git Trees - linux/.git/commitdiff
tracing: Remove unneeded event_mutex lock in event_trigger_regex_release()
authorSteven Rostedt <rostedt@goodmis.org>
Tue, 25 Nov 2025 21:40:05 +0000 (16:40 -0500)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Wed, 26 Nov 2025 20:13:29 +0000 (15:13 -0500)
In event_trigger_regex_release(), the only code is:

mutex_lock(&event_mutex);
if (file->f_mode & FMODE_READ)
seq_release(inode, file);
mutex_unlock(&event_mutex);

return 0;

There's nothing special about the file->f_mode or the seq_release() that
requires any locking. Remove the unnecessary locks.

Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Tom Zanussi <zanussi@kernel.org>
Link: https://patch.msgid.link/20251125214031.975879283@kernel.org
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_events_trigger.c

index 7795af600466fc67db59e017d1fc32dc729f64a2..e5dcfcbb2cd585d6aaa3a8b3b3043488d1bf413b 100644 (file)
@@ -314,13 +314,9 @@ static ssize_t event_trigger_regex_write(struct file *file,
 
 static int event_trigger_regex_release(struct inode *inode, struct file *file)
 {
-       mutex_lock(&event_mutex);
-
        if (file->f_mode & FMODE_READ)
                seq_release(inode, file);
 
-       mutex_unlock(&event_mutex);
-
        return 0;
 }