]> Gentwo Git Trees - linux/.git/commitdiff
cxl/region: Remove local variable @inc in cxl_port_setup_targets()
authorRobert Richter <rrichter@amd.com>
Fri, 14 Nov 2025 07:58:43 +0000 (08:58 +0100)
committerDave Jiang <dave.jiang@intel.com>
Fri, 14 Nov 2025 17:37:29 +0000 (10:37 -0700)
Simplify the code by removing local variable @inc. The variable is not
used elsewhere, remove it and directly increment the target number.

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Robert Richter <rrichter@amd.com>
Link: https://patch.msgid.link/20251114075844.1315805-4-rrichter@amd.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/core/region.c

index 095af0f4760fb8f22087cd30cf61d27011c4f131..8cdb6a935289b625ddabd99db518645c26c35256 100644 (file)
@@ -1328,7 +1328,7 @@ static int cxl_port_setup_targets(struct cxl_port *port,
                                  struct cxl_endpoint_decoder *cxled)
 {
        struct cxl_root_decoder *cxlrd = to_cxl_root_decoder(cxlr->dev.parent);
-       int parent_iw, parent_ig, ig, iw, rc, inc = 0, pos = cxled->pos;
+       int parent_iw, parent_ig, ig, iw, rc, pos = cxled->pos;
        struct cxl_port *parent_port = to_cxl_port(port->dev.parent);
        struct cxl_region_ref *cxl_rr = cxl_rr_load(port, cxlr);
        struct cxl_memdev *cxlmd = cxled_to_memdev(cxled);
@@ -1520,9 +1520,8 @@ static int cxl_port_setup_targets(struct cxl_port *port,
                cxlsd->target[cxl_rr->nr_targets_set] = ep->dport;
                cxlsd->cxld.target_map[cxl_rr->nr_targets_set] = ep->dport->port_id;
        }
-       inc = 1;
+       cxl_rr->nr_targets_set++;
 out_target_set:
-       cxl_rr->nr_targets_set += inc;
        dev_dbg(&cxlr->dev, "%s:%s target[%d] = %s for %s:%s @ %d\n",
                dev_name(port->uport_dev), dev_name(&port->dev),
                cxl_rr->nr_targets_set - 1, dev_name(ep->dport->dport_dev),