]> Gentwo Git Trees - linux/.git/commitdiff
drm/rockchip: analogix_dp: Use dev_err_probe() instead of DRM_DEV_ERROR() during...
authorDamon Ding <damon.ding@rock-chips.com>
Mon, 10 Nov 2025 07:58:17 +0000 (15:58 +0800)
committerHeiko Stuebner <heiko@sntech.de>
Fri, 14 Nov 2025 21:57:53 +0000 (22:57 +0100)
The DRM_DEV_ERROR() has been deprecated, and use dev_err_probe()
can be better. The other reason is that dev_err_probe() help avoid
unexpected repeated err logs during defered probing.

Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20251110075817.1159857-1-damon.ding@rock-chips.com
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c

index d30fef00c34ceb874e6b24a62d6e156514cd6ae8..fdab71d51e2a71d644f128b1bf1c39429b4ad52a 100644 (file)
@@ -331,32 +331,29 @@ static int rockchip_dp_of_probe(struct rockchip_dp_device *dp)
        struct device_node *np = dev->of_node;
 
        dp->grf = syscon_regmap_lookup_by_phandle(np, "rockchip,grf");
-       if (IS_ERR(dp->grf)) {
-               DRM_DEV_ERROR(dev, "failed to get rockchip,grf property\n");
-               return PTR_ERR(dp->grf);
-       }
+       if (IS_ERR(dp->grf))
+               return dev_err_probe(dev, PTR_ERR(dp->grf),
+                                    "failed to get rockchip,grf property\n");
 
        dp->grfclk = devm_clk_get_optional(dev, "grf");
        if (IS_ERR(dp->grfclk))
-               return dev_err_probe(dev, PTR_ERR(dp->grfclk), "failed to get grf clock\n");
+               return dev_err_probe(dev, PTR_ERR(dp->grfclk),
+                                    "failed to get grf clock\n");
 
        dp->pclk = devm_clk_get(dev, "pclk");
-       if (IS_ERR(dp->pclk)) {
-               DRM_DEV_ERROR(dev, "failed to get pclk property\n");
-               return PTR_ERR(dp->pclk);
-       }
+       if (IS_ERR(dp->pclk))
+               return dev_err_probe(dev, PTR_ERR(dp->pclk),
+                                    "failed to get pclk property\n");
 
        dp->rst = devm_reset_control_get(dev, "dp");
-       if (IS_ERR(dp->rst)) {
-               DRM_DEV_ERROR(dev, "failed to get dp reset control\n");
-               return PTR_ERR(dp->rst);
-       }
+       if (IS_ERR(dp->rst))
+               return dev_err_probe(dev, PTR_ERR(dp->rst),
+                                    "failed to get dp reset control\n");
 
        dp->apbrst = devm_reset_control_get_optional(dev, "apb");
-       if (IS_ERR(dp->apbrst)) {
-               DRM_DEV_ERROR(dev, "failed to get apb reset control\n");
-               return PTR_ERR(dp->apbrst);
-       }
+       if (IS_ERR(dp->apbrst))
+               return dev_err_probe(dev, PTR_ERR(dp->apbrst),
+                                    "failed to get apb reset control\n");
 
        return 0;
 }