]> Gentwo Git Trees - linux/.git/commitdiff
power: supply: rt9467: Return error on failure in rt9467_set_value_from_ranges()
authorIvan Abramov <i.abramov@mt-integration.ru>
Thu, 9 Oct 2025 14:47:24 +0000 (17:47 +0300)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Mon, 3 Nov 2025 00:01:57 +0000 (01:01 +0100)
The return value of rt9467_set_value_from_ranges() when setting AICL VTH is
not checked, even though it may fail.

Log error and return from rt9467_run_aicl() on fail.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 6f7f70e3a8dd ("power: supply: rt9467: Add Richtek RT9467 charger driver")
Signed-off-by: Ivan Abramov <i.abramov@mt-integration.ru>
Link: https://patch.msgid.link/20251009144725.562278-1-i.abramov@mt-integration.ru
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/rt9467-charger.c

index fe773dd8b404f3c8130aab7df401ba40935240cc..b4917514bd701cbec405db5cf36d622912d6be79 100644 (file)
@@ -588,6 +588,10 @@ static int rt9467_run_aicl(struct rt9467_chg_data *data)
        aicl_vth = mivr_vth + RT9467_AICLVTH_GAP_uV;
        ret = rt9467_set_value_from_ranges(data, F_AICL_VTH,
                                           RT9467_RANGE_AICL_VTH, aicl_vth);
+       if (ret) {
+               dev_err(data->dev, "Failed to set AICL VTH\n");
+               return ret;
+       }
 
        /* Trigger AICL function */
        ret = regmap_field_write(data->rm_field[F_AICL_MEAS], 1);