drm/panel: ronbo-rb070d30: fix warning with gpio controllers that sleep

The ronbo-rb070d30 controles the various gpios for reset, standby,
vertical and horizontal flip using the non-sleeping gpiod_set_value()
function.

Switch to using gpiod_set_value_cansleep() when controlling reset_gpio to
support GPIO providers that may sleep, such as I2C GPIO expanders.

This fixes noisy complaints in kernel log for gpio providers that do
sleep.

Signed-off-by: Josua Mayer <josua@solid-run.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patch.msgid.link/20251117-imx8mp-hb-iiot-v3-5-bf1a4cf5fa8e@solid-run.com

diff --git a/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
index ad35d0fb0a16787ffb87c365c9939c78ff42d67a..c3fbc459c7e0d019aee0f90bf04e6a7dfd50a95d 100644 (file)
--- a/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
+++ b/drivers/gpu/drm/panel/panel-ronbo-rb070d30.c
@@ -54,9 +54,9 @@ static int rb070d30_panel_prepare(struct drm_panel *panel)
        }
 
        msleep(20);
-       gpiod_set_value(ctx->gpios.power, 1);
+       gpiod_set_value_cansleep(ctx->gpios.power, 1);
        msleep(20);
-       gpiod_set_value(ctx->gpios.reset, 1);
+       gpiod_set_value_cansleep(ctx->gpios.reset, 1);
        msleep(20);
        return 0;
 }
@@ -65,8 +65,8 @@ static int rb070d30_panel_unprepare(struct drm_panel *panel)
 {
        struct rb070d30_panel *ctx = panel_to_rb070d30_panel(panel);
 
-       gpiod_set_value(ctx->gpios.reset, 0);
-       gpiod_set_value(ctx->gpios.power, 0);
+       gpiod_set_value_cansleep(ctx->gpios.reset, 0);
+       gpiod_set_value_cansleep(ctx->gpios.power, 0);
        regulator_disable(ctx->supply);
 
        return 0;