]> Gentwo Git Trees - linux/.git/commitdiff
drm/plane: Remove const qualifier from plane->modifiers allocation type
authorKees Cook <kees@kernel.org>
Sat, 26 Apr 2025 06:13:26 +0000 (23:13 -0700)
committerKees Cook <kees@kernel.org>
Mon, 24 Nov 2025 20:43:52 +0000 (12:43 -0800)
In preparation for making the kmalloc family of allocators type aware,
we need to make sure that the returned type from the allocation matches
the type of the variable being assigned. (Before, the allocator would
always return "void *", which can be implicitly cast to any pointer type.)

The assigned type is "uint64_t *", but the returned type, while matching,
will be const qualified. As there is no general way to remove const
qualifiers, adjust the allocation type to match the assignment.

Link: https://patch.msgid.link/20250426061325.work.665-kees@kernel.org
Signed-off-by: Kees Cook <kees@kernel.org>
drivers/gpu/drm/drm_plane.c

index 38f82391bfda578d532499585066dd85ff573910..f54ad04c9cd4a9c34d19a0e0e4ee84d57889a469 100644 (file)
@@ -425,7 +425,7 @@ static int __drm_universal_plane_init(struct drm_device *dev,
 
        plane->modifier_count = format_modifier_count;
        plane->modifiers = kmalloc_array(format_modifier_count,
-                                        sizeof(format_modifiers[0]),
+                                        sizeof(*plane->modifiers),
                                         GFP_KERNEL);
 
        if (format_modifier_count && !plane->modifiers) {