]> Gentwo Git Trees - linux/.git/commitdiff
drm/msm/a2xx: stop over-complaining about the legacy firmware
authorDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Thu, 13 Nov 2025 20:40:50 +0000 (22:40 +0200)
committerRob Clark <rob.clark@oss.qualcomm.com>
Mon, 17 Nov 2025 17:43:58 +0000 (09:43 -0800)
If the rootfs have a legacy A200 firmware, currently the driver will
complain each time the hw is reinited (which can happen a lot). E.g.
with GL testsuite the hw is reinited after each test, spamming the
console.

Make sure that the message is printed only once: when we detect the
firmware that doesn't support protection.

Fixes: 302295070d3c ("drm/msm/a2xx: support loading legacy (iMX) firmware")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/688098/
Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
drivers/gpu/drm/msm/adreno/a2xx_gpu.c

index ec38db45d8a366e75acddbacd4810d7b7a80926f..963c0f669ee50d4568b521e2e8548e04d606d9ca 100644 (file)
@@ -234,7 +234,7 @@ static int a2xx_hw_init(struct msm_gpu *gpu)
         * word (0x20xxxx for A200, 0x220xxx for A220, 0x225xxx for A225).
         * Older firmware files, which lack protection support, have 0 instead.
         */
-       if (ptr[1] == 0) {
+       if (ptr[1] == 0 && !a2xx_gpu->protection_disabled) {
                dev_warn(gpu->dev->dev,
                         "Legacy firmware detected, disabling protection support\n");
                a2xx_gpu->protection_disabled = true;