]> Gentwo Git Trees - linux/.git/commitdiff
iommu/apple-dart: fix device leak on of_xlate()
authorJohan Hovold <johan@kernel.org>
Mon, 20 Oct 2025 04:53:05 +0000 (06:53 +0200)
committerJoerg Roedel <joerg.roedel@amd.com>
Mon, 17 Nov 2025 08:49:42 +0000 (09:49 +0100)
Make sure to drop the reference taken to the iommu platform device when
looking up its driver data during of_xlate().

Fixes: 46d1fb072e76 ("iommu/dart: Add DART iommu driver")
Cc: stable@vger.kernel.org # 5.15
Cc: Sven Peter <sven@kernel.org>
Acked-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
drivers/iommu/apple-dart.c

index b5848770ef482fd196374a742d2e1cc08f5dc366..83a5aabcd15d97db4eebf60beac590e5201d2b5b 100644 (file)
@@ -805,6 +805,8 @@ static int apple_dart_of_xlate(struct device *dev,
        struct apple_dart *cfg_dart;
        int i, sid;
 
+       put_device(&iommu_pdev->dev);
+
        if (args->args_count != 1)
                return -EINVAL;
        sid = args->args[0];