fbdev: Make drivers depend on FB_TILEBLITTING

The option CONFIG_FB_TILEBLITTING is controlled by the user. Selecting
it from drivers can lead to cyclic dependencies within the config. In
fbcon, there's special handling for tile blitting, which currently
cannot be disabled without first disabling the relevant fbdev drivers.
Fix the Kconfig dependency to make it work.

Some guidelines for using select can be found in the kernel docs at [1].

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://elixir.bootlin.com/linux/v6.16/source/Documentation/kbuild/kconfig-language.rst#L147
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20250909132047.152612-2-tzimmermann@suse.de

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index c21484d15f0cbde9b8396688f2a60c3c72456c0e..6cea1449b4c5d8d0beb3f699b546816d03892525 100644 (file)
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -816,11 +816,11 @@ config FB_I810_I2C
 config FB_MATROX
        tristate "Matrox acceleration"
        depends on FB && PCI
+       depends on FB_TILEBLITTING
        select FB_CFB_FILLRECT
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT
        select FB_IOMEM_FOPS
-       select FB_TILEBLITTING
        select FB_MACMODES if PPC_PMAC
        help
          Say Y here if you have a Matrox Millennium, Matrox Millennium II,
@@ -1053,11 +1053,11 @@ config FB_ATY_BACKLIGHT
 config FB_S3
        tristate "S3 Trio/Virge support"
        depends on FB && PCI && HAS_IOPORT
+       depends on FB_TILEBLITTING
        select FB_CFB_FILLRECT
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT
        select FB_IOMEM_FOPS
-       select FB_TILEBLITTING
        select FB_SVGALIB
        select VGASTATE
        select FONT_8x16 if FRAMEBUFFER_CONSOLE
@@ -1258,11 +1258,11 @@ config FB_VOODOO1
 config FB_VT8623
        tristate "VIA VT8623 support"
        depends on FB && PCI && HAS_IOPORT
+       depends on FB_TILEBLITTING
        select FB_CFB_FILLRECT
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT
        select FB_IOMEM_FOPS
-       select FB_TILEBLITTING
        select FB_SVGALIB
        select VGASTATE
        select FONT_8x16 if FRAMEBUFFER_CONSOLE
@@ -1296,11 +1296,11 @@ config FB_TRIDENT
 config FB_ARK
        tristate "ARK 2000PV support"
        depends on FB && PCI && HAS_IOPORT
+       depends on FB_TILEBLITTING
        select FB_CFB_FILLRECT
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT
        select FB_IOMEM_FOPS
-       select FB_TILEBLITTING
        select FB_SVGALIB
        select VGASTATE
        select FONT_8x16 if FRAMEBUFFER_CONSOLE