]> Gentwo Git Trees - linux/.git/commitdiff
tracing: Convert function graph set_flags() to use a switch() statement
authorSteven Rostedt <rostedt@goodmis.org>
Fri, 14 Nov 2025 19:22:33 +0000 (14:22 -0500)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Fri, 14 Nov 2025 19:30:55 +0000 (14:30 -0500)
Currently the set_flags() of the function graph tracer has a bunch of:

  if (bit == FLAG1) {
[..]
  }

  if (bit == FLAG2) {
[..]
  }

To clean it up a bit, convert it over to a switch statement.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Link: https://patch.msgid.link/20251114192319.117123664@kernel.org
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_functions_graph.c

index 12315eb65925d6c5ac54637fc4e71bae304952cf..44d5dc5031e21d4f7e9e4c649a960463bc224130 100644 (file)
@@ -1664,7 +1664,8 @@ func_graph_set_flag(struct trace_array *tr, u32 old_flags, u32 bit, int set)
        if (!!set == !!(tr->current_trace_flags->val & bit))
                return 0;
 
-       if (bit == TRACE_GRAPH_SLEEP_TIME) {
+       switch (bit) {
+       case TRACE_GRAPH_SLEEP_TIME:
                if (set) {
                        fgraph_no_sleep_time--;
                        if (WARN_ON_ONCE(fgraph_no_sleep_time < 0))
@@ -1672,19 +1673,20 @@ func_graph_set_flag(struct trace_array *tr, u32 old_flags, u32 bit, int set)
                } else {
                        fgraph_no_sleep_time++;
                }
-       }
+               break;
 
-       if (bit == TRACE_GRAPH_PRINT_IRQS) {
+       case TRACE_GRAPH_PRINT_IRQS:
                if (set)
                        ftrace_graph_skip_irqs--;
                else
                        ftrace_graph_skip_irqs++;
                if (WARN_ON_ONCE(ftrace_graph_skip_irqs < 0))
                        ftrace_graph_skip_irqs = 0;
-       }
+               break;
 
-       if (bit == TRACE_GRAPH_ARGS)
+       case TRACE_GRAPH_ARGS:
                return ftrace_graph_trace_args(tr, set);
+       }
 
        return 0;
 }