]> Gentwo Git Trees - linux/.git/commitdiff
drm/i915/gt: Use pci_rebar_size_supported()
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 13 Nov 2025 18:00:48 +0000 (20:00 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 14 Nov 2025 18:34:21 +0000 (12:34 -0600)
PCI core provides pci_rebar_size_supported() that helps in checking if an
encoded BAR Size is supported for the BAR or not. Use it in
i915_resize_lmem_bar() to simplify code.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Acked-by: Christian König <christian.koenig@amd.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patch.msgid.link/20251113180053.27944-7-ilpo.jarvinen@linux.intel.com
drivers/gpu/drm/i915/gt/intel_region_lmem.c

index c37a0560ebe0b64208859cff5d73a36ed515c480..15e83ce00eff904e5f1c022004f6d91c70a717a9 100644 (file)
@@ -49,16 +49,12 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
        current_size = roundup_pow_of_two(pci_resource_len(pdev, GEN12_LMEM_BAR));
 
        if (i915->params.lmem_bar_size) {
-               u32 bar_sizes;
-
-               rebar_size = i915->params.lmem_bar_size *
-                       (resource_size_t)SZ_1M;
-               bar_sizes = pci_rebar_get_possible_sizes(pdev, GEN12_LMEM_BAR);
-
+               rebar_size = i915->params.lmem_bar_size * (resource_size_t)SZ_1M;
                if (rebar_size == current_size)
                        return;
 
-               if (!(bar_sizes & BIT(pci_rebar_bytes_to_size(rebar_size))) ||
+               if (!pci_rebar_size_supported(pdev, GEN12_LMEM_BAR,
+                                             pci_rebar_bytes_to_size(rebar_size)) ||
                    rebar_size >= roundup_pow_of_two(lmem_size)) {
                        rebar_size = lmem_size;