]> Gentwo Git Trees - linux/.git/commitdiff
mtd: rawnand: sunxi: Remove superfluous register readings
authorRichard Genoud <richard.genoud@bootlin.com>
Tue, 28 Oct 2025 07:34:55 +0000 (08:34 +0100)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Tue, 28 Oct 2025 16:16:01 +0000 (17:16 +0100)
The register NFC_REG_ECC_CTL was read twice and the result was not used,
then a third time with a mask applied.
Removing those calls didn't change the behavior.

Tested on H616 SoC, scrambling enabled.

Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Richard Genoud <richard.genoud@bootlin.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/raw/sunxi_nand.c

index f6a8e8ae819d4ac9e53c4b317bccfb968bf81369..cb12179b63a5dc150aa821b07629870850c78d12 100644 (file)
@@ -623,13 +623,12 @@ static void sunxi_nfc_randomizer_config(struct nand_chip *nand, int page,
                                        bool ecc)
 {
        struct sunxi_nfc *nfc = to_sunxi_nfc(nand->controller);
-       u32 ecc_ctl = readl(nfc->regs + NFC_REG_ECC_CTL);
+       u32 ecc_ctl;
        u16 state;
 
        if (!(nand->options & NAND_NEED_SCRAMBLING))
                return;
 
-       ecc_ctl = readl(nfc->regs + NFC_REG_ECC_CTL);
        state = sunxi_nfc_randomizer_state(nand, page, ecc);
        ecc_ctl = readl(nfc->regs + NFC_REG_ECC_CTL) & ~NFC_RANDOM_SEED_MSK;
        writel(ecc_ctl | NFC_RANDOM_SEED(state), nfc->regs + NFC_REG_ECC_CTL);