]> Gentwo Git Trees - linux/.git/commitdiff
mfd: simple-mfd-i2c: Remove select I2C_K1 from MFD_SPACEMIT_P1
authorTroy Mitchell <troy.mitchell@linux.spacemit.com>
Mon, 27 Oct 2025 05:48:05 +0000 (13:48 +0800)
committerLee Jones <lee@kernel.org>
Thu, 6 Nov 2025 16:03:41 +0000 (16:03 +0000)
select will force a symbol to a specific value without considering
its dependencies. As a result, the i2c-k1 driver will fail to build
when OF or COMMON_CLK are disabled.

The reason for removing I2C_K1 instead of adding a depends on condition
is to keep the possibility for other SoCs to use this PMIC.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202510211523.sSEVqPUQ-lkp@intel.com/
Acked-by: Alex Elder <elder@riscstar.com>
Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Link: https://lore.kernel.org/all/20251022004830-GYB1522542@gentoo.org/
Link: https://patch.msgid.link/20251027-p1-kconfig-fix-v2-1-49688f30bae8@linux.spacemit.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/Kconfig

index dbeac6825a10819cc1fb2b51d78e64a2219dc9a7..58bfe32453a2d43a6b31338f861a1f176d77a7c4 100644 (file)
@@ -1275,7 +1275,6 @@ config MFD_SPACEMIT_P1
        tristate "SpacemiT P1 PMIC"
        depends on ARCH_SPACEMIT || COMPILE_TEST
        depends on I2C
-       select I2C_K1
        select MFD_SIMPLE_MFD_I2C
        help
          This option supports the I2C-based SpacemiT P1 PMIC, which