]> Gentwo Git Trees - linux/.git/commitdiff
bnxt_en: Enhance log message in bnxt_get_module_status()
authorGautam R A <gautam-r.a@broadcom.com>
Wed, 26 Nov 2025 21:56:43 +0000 (13:56 -0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 28 Nov 2025 02:59:28 +0000 (18:59 -0800)
Rturn early with -EOPNOTSUPP and an extack message if the PHY type is
BaseT since module status is not available for BaseT.

Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: Gautam R A <gautam-r.a@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20251126215648.1885936-3-michael.chan@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

index baac639f9c9418404b8556867d43d6f4cb90f951..efb9bf20e66b023400004f2a15d5b05af52f824c 100644 (file)
@@ -4623,6 +4623,11 @@ static int bnxt_get_module_status(struct bnxt *bp, struct netlink_ext_ack *extac
            PORT_PHY_QCFG_RESP_MODULE_STATUS_WARNINGMSG)
                return 0;
 
+       if (bp->link_info.phy_type == PORT_PHY_QCFG_RESP_PHY_TYPE_BASET ||
+           bp->link_info.phy_type == PORT_PHY_QCFG_RESP_PHY_TYPE_BASETE){
+               NL_SET_ERR_MSG_MOD(extack, "Operation not supported as PHY type is Base-T");
+               return -EOPNOTSUPP;
+       }
        switch (bp->link_info.module_status) {
        case PORT_PHY_QCFG_RESP_MODULE_STATUS_PWRDOWN:
                NL_SET_ERR_MSG_MOD(extack, "Transceiver module is powering down");