]> Gentwo Git Trees - linux/.git/commitdiff
net: dsa: tag_hellcreek: use the dsa_xmit_port_mask() helper
authorVladimir Oltean <vladimir.oltean@nxp.com>
Thu, 27 Nov 2025 12:08:51 +0000 (14:08 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 29 Nov 2025 04:03:39 +0000 (20:03 -0800)
The "hellcreek" tagging protocol populates a bit mask for the TX ports,
so we can use dsa_xmit_port_mask() to centralize the decision of how to
set that field.

Cc: Kurt Kanzenbach <kurt@linutronix.de>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20251127120902.292555-5-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/dsa/tag_hellcreek.c

index 663b25785d958bfa00016da79466fc8d96475465..544ab15685a2b80ca9404a2524f5c728a65e1262 100644 (file)
@@ -20,7 +20,6 @@
 static struct sk_buff *hellcreek_xmit(struct sk_buff *skb,
                                      struct net_device *dev)
 {
-       struct dsa_port *dp = dsa_user_to_port(dev);
        u8 *tag;
 
        /* Calculate checksums (if required) before adding the trailer tag to
@@ -33,7 +32,7 @@ static struct sk_buff *hellcreek_xmit(struct sk_buff *skb,
 
        /* Tag encoding */
        tag  = skb_put(skb, HELLCREEK_TAG_LEN);
-       *tag = BIT(dp->index);
+       *tag = dsa_xmit_port_mask(skb, dev);
 
        return skb;
 }