From: Josef Bacik <jbacik@fusionio.com>
Date: Fri, 19 Apr 2013 18:37:26 +0000 (-0400)
Subject: Btrfs: fix possible infinite loop in slow caching
X-Git-Tag: v3.10-rc1~31^2~37
X-Git-Url: https://gentwo.org/gitweb/?a=commitdiff_plain;h=0a3896d0f563d4472c75ab2c26afd8940d24b5a1;p=linux%2F.git

Btrfs: fix possible infinite loop in slow caching

So I noticed there is an infinite loop in the slow caching code.  If we return 1
when we hit the end of the tree, so we could end up caching the last block group
the slow way and suddenly we're looping forever because we just keep
re-searching and trying again.  Fix this by only doing btrfs_next_leaf() if we
don't need_resched().  Thanks,

Signed-off-by: Josef Bacik <jbacik@fusionio.com>
---

diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 8464d369e478..fa57965f60a3 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -419,8 +419,7 @@ static noinline void caching_thread(struct btrfs_work *work)
 			if (ret)
 				break;
 
-			if (need_resched() ||
-			    btrfs_next_leaf(extent_root, path)) {
+			if (need_resched()) {
 				caching_ctl->progress = last;
 				btrfs_release_path(path);
 				up_read(&fs_info->extent_commit_sem);
@@ -428,6 +427,12 @@ static noinline void caching_thread(struct btrfs_work *work)
 				cond_resched();
 				goto again;
 			}
+
+			ret = btrfs_next_leaf(extent_root, path);
+			if (ret < 0)
+				goto err;
+			if (ret)
+				break;
 			leaf = path->nodes[0];
 			nritems = btrfs_header_nritems(leaf);
 			continue;