]> Gentwo Git Trees - linux/.git/commit
drm/xe/hw_engine_group: Fix double write lock release in error path
authorShuicheng Lin <shuicheng.lin@intel.com>
Thu, 25 Sep 2025 02:31:46 +0000 (02:31 +0000)
committerLucas De Marchi <lucas.demarchi@intel.com>
Fri, 26 Sep 2025 13:44:18 +0000 (06:44 -0700)
commit662d98b8b373007fa1b08ba93fee11f6fd3e387c
treee98264a02aed4d499f073f7b86ec94bedc4320b6
parenta4916b4da44812384388ac09a2baf9da461dbc30
drm/xe/hw_engine_group: Fix double write lock release in error path

In xe_hw_engine_group_get_mode(), a write lock is acquired before
calling switch_mode(), which in turn invokes
xe_hw_engine_group_suspend_faulting_lr_jobs().

On failure inside xe_hw_engine_group_suspend_faulting_lr_jobs(),
the write lock is released there, and then again in
xe_hw_engine_group_get_mode(), leading to a double release.

Fix this by keeping both acquire and release operation in
xe_hw_engine_group_get_mode().

Fixes: 770bd1d34113 ("drm/xe/hw_engine_group: Ensure safe transition between execution modes")
Cc: Francois Dugast <francois.dugast@intel.com>
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
Reviewed-by: Francois Dugast <francois.dugast@intel.com>
Link: https://lore.kernel.org/r/20250925023145.1203004-2-shuicheng.lin@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_hw_engine_group.c