From 505c3ec507a7eb4bbaef9aa8b13b6452e86baca2 Mon Sep 17 00:00:00 2001 From: Alexandre Courbot Date: Wed, 29 Oct 2025 08:12:10 +0900 Subject: [PATCH] gpu: nova-core: vbios: do not use `as` when comparing BiosImageType Use the `image_type` method and compare its result to avoid using `as`. Reviewed-by: Joel Fernandes Signed-off-by: Alexandre Courbot Message-ID: <20251029-nova-as-v3-2-6a30c7333ad9@nvidia.com> --- drivers/gpu/nova-core/vbios.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nova-core/vbios.rs b/drivers/gpu/nova-core/vbios.rs index 74ed6d61e6cc..9283921e89c3 100644 --- a/drivers/gpu/nova-core/vbios.rs +++ b/drivers/gpu/nova-core/vbios.rs @@ -709,9 +709,8 @@ impl BiosImage { /// Check if this is the last image. fn is_last(&self) -> bool { - // For NBSI images (type == 0x70), return true as they're - // considered the last image - if self.pcir.code_type == BiosImageType::Nbsi as u8 { + // For NBSI images, return true as they're considered the last image. + if self.image_type() == Ok(BiosImageType::Nbsi) { return true; } -- 2.47.3