From 651765e8d527427e1d91fb7f606c5506f437f622 Mon Sep 17 00:00:00 2001 From: Hangbin Liu Date: Tue, 25 Nov 2025 11:20:48 +0000 Subject: [PATCH] netlink: specs: add big-endian byte-order for u32 IPv4 addresses MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The fix commit converted several IPv4 address attributes from binary to u32, but forgot to specify byte-order: big-endian. Without this, YNL tools display IPv4 addresses incorrectly due to host-endian interpretation. Add the missing byte-order: big-endian to all affected u32 IPv4 address fields to ensure correct parsing and display. Fixes: 1064d521d177 ("netlink: specs: support ipv4-or-v6 for dual-stack fields") Reported-by: Paolo Abeni Signed-off-by: Hangbin Liu Reviewed-by: Asbjørn Sloth Tønnesen Link: https://patch.msgid.link/20251125112048.37631-1-liuhangbin@gmail.com Signed-off-by: Jakub Kicinski --- Documentation/netlink/specs/rt-addr.yaml | 1 + Documentation/netlink/specs/rt-link.yaml | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Documentation/netlink/specs/rt-addr.yaml b/Documentation/netlink/specs/rt-addr.yaml index abcbaa73fa9d..163a106c41bb 100644 --- a/Documentation/netlink/specs/rt-addr.yaml +++ b/Documentation/netlink/specs/rt-addr.yaml @@ -97,6 +97,7 @@ attribute-sets: - name: broadcast type: u32 + byte-order: big-endian display-hint: ipv4 - name: anycast diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml index ca22c68ca691..6beeb6ee5adf 100644 --- a/Documentation/netlink/specs/rt-link.yaml +++ b/Documentation/netlink/specs/rt-link.yaml @@ -1869,6 +1869,7 @@ attribute-sets: - name: remote type: u32 + byte-order: big-endian display-hint: ipv4 - name: ttl @@ -1987,6 +1988,7 @@ attribute-sets: - name: 6rd-relay-prefix type: u32 + byte-order: big-endian display-hint: ipv4 - name: 6rd-prefixlen -- 2.47.3