From 9c5053083eeecc7a2cd6c1271a85087e73820ae2 Mon Sep 17 00:00:00 2001 From: Steven Rostedt Date: Wed, 5 Nov 2025 19:33:25 -0500 Subject: [PATCH] tracing: Exit out immediately after update_marker_trace() The call to update_marker_trace() in set_tracer_flag() performs the update to the tr->trace_flags. There's no reason to perform it again after it is called. Return immediately instead. Cc: Mark Rutland Cc: Mathieu Desnoyers Cc: Andrew Morton Link: https://patch.msgid.link/20251106003501.726406870@kernel.org Reviewed-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index ed929d331e1d..88234b541b09 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -5254,8 +5254,11 @@ int set_tracer_flag(struct trace_array *tr, u64 mask, int enabled) } } - if (mask == TRACE_ITER(COPY_MARKER)) + if (mask == TRACE_ITER(COPY_MARKER)) { update_marker_trace(tr, enabled); + /* update_marker_trace updates the tr->trace_flags */ + return 0; + } if (enabled) tr->trace_flags |= mask; -- 2.47.3